Use compatPatrouille
#410
Merged
Use compatPatrouille
#410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Refactors project configuration to align with the updated compatPatrouille setup by bumping version catalogs, updating resource imports, and adjusting plugin ordering.
- Upgraded the version-catalog dependency to
0.4.2 - Switched the Web sample’s WASM instantiation import to use
markdown.uninstantiated.mjs - Reordered plugins in the shared Gradle build script
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| settings.gradle.kts | Bumped version-catalog from 0.3.9 to 0.4.2 |
| sample/web/src/commonMain/resources/load.mjs | Changed import from aboutlibraries to markdown |
| sample/shared/build.gradle.kts | Moved Kotlin Multiplatform plugin below Android |
Comments suppressed due to low confidence (1)
sample/shared/build.gradle.kts:3
- Reordering the Kotlin Multiplatform plugin after the Android Library plugin can lead to configuration issues, as KMP should be applied first to set up targets correctly. Consider restoring the original order or validating that multiplatform targets still resolve as expected.
id("com.mikepenz.convention.kotlin-multiplatform")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
compatPatrouilleType of change
Please delete options that are not relevant.